extension/src/goTest: skip testdata directories in test discovery - #4074
Open
ChrisJr404 wants to merge 1 commit into
Open
extension/src/goTest: skip testdata directories in test discovery#4074ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
The Test Explorer walks the workspace to discover _test.go files, but it descended into testdata directories too. The go command treats testdata as inert, so tests defined there aren't real and shouldn't appear in the tree. walk now skips directories named testdata, which keeps both walkWorkspaces and walkPackages from descending into them. That covers discovery through the tree, but a user can still open a _test.go file that lives under a testdata directory directly, so processDocument returns early when the document's path contains a testdata segment. Added resolver tests for both paths: a testdata package is skipped during module resolution, and a file opened from within testdata resolves no tests. Fixes golang#1854
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Test Explorer walks the workspace to discover _test.go files, but it
descended into testdata directories too. The go command treats testdata
as inert, so tests defined there aren't real and shouldn't appear in the
tree.
walk now skips directories named testdata, which keeps both walkWorkspaces
and walkPackages from descending into them. That covers discovery through
the tree, but a user can still open a _test.go file that lives under a
testdata directory directly, so processDocument returns early when the
document's path contains a testdata segment. This follows the approach
firelizzard18 outlined on the issue.
Added resolver tests for both paths: a testdata package is skipped during
module resolution, and a file opened from within testdata resolves no
tests.
Fixes #1854