_content/doc/tutorial: fix variable name typo in JSON tutorial - #376
Open
samuraiigintoki wants to merge 1 commit into
Open
_content/doc/tutorial: fix variable name typo in JSON tutorial#376samuraiigintoki wants to merge 1 commit into
samuraiigintoki wants to merge 1 commit into
Conversation
In the "Custom Marshal and Unmarshal" section of the JSON tutorial,
the code snippet initializes `v := Version{1, 2, 3}`, but incorrectly passes
`s` to `json.Marshal(s)`.
Change `json.Marshal(s)` to `json.Marshal(v)` to match the declared variable.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
This PR (HEAD: 7df437e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/821840. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the "Custom Marshal and Unmarshal" section of the JSON tutorial,
the code snippet initializes
v := Version{1, 2, 3}, but incorrectlypasses
stojson.Marshal(s).Change
json.Marshal(s)tojson.Marshal(v)to match the declaredvariable.