Skip to content

Add tests-on-macos#1279

Merged
ernado merged 1 commit into
masterfrom
latest
Aug 4, 2020
Merged

Add tests-on-macos#1279
ernado merged 1 commit into
masterfrom
latest

Conversation

@SVilgelm
Copy link
Copy Markdown
Member

@SVilgelm SVilgelm commented Aug 2, 2020

IMO we need to run the tests on macOS in same way we do for windows, so I added tests-on-macos as a parallel job with the go v1.14, so only ubuntu job will use different go version for testing.

@SVilgelm
Copy link
Copy Markdown
Member Author

SVilgelm commented Aug 2, 2020

@golangci/core-team @jirfag @ernado Could you please review this and if you are OK, then please modify the branch protection

@SVilgelm SVilgelm changed the title Use the latest version of golangci-lint in action Add tests-on-macos Aug 2, 2020
@SVilgelm SVilgelm force-pushed the latest branch 6 times, most recently from 7353d85 to 054c88a Compare August 3, 2020 18:57
@SVilgelm SVilgelm changed the title Add tests-on-macos WIP Add tests-on-macos Aug 3, 2020
@SVilgelm SVilgelm force-pushed the latest branch 6 times, most recently from 0206e42 to a28a905 Compare August 3, 2020 19:32
@SVilgelm
Copy link
Copy Markdown
Member Author

SVilgelm commented Aug 3, 2020

@ernado Could you make same changes here for the branch protection?

@SVilgelm SVilgelm changed the title WIP Add tests-on-macos Add tests-on-macos Aug 3, 2020
Copy link
Copy Markdown
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernado
Copy link
Copy Markdown
Member

ernado commented Aug 4, 2020

I've updated protected branch rules.

@ernado ernado merged commit 703f2af into master Aug 4, 2020
@delete-merged-branch delete-merged-branch Bot deleted the latest branch August 4, 2020 18:34
@ldez ldez added the area: ci PR that update CI label Dec 7, 2020
@ldez ldez added this to the v1.31 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci PR that update CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants