Upgrade go 1.15 for smaller binary#1303
Merged
Merged
Conversation
Member
Author
|
checking on failed test, so mark this one as draft |
Member
|
LGTM |
Member
|
please also check for performance regressions on large repos, e.g. on k8s |
|
I believe this will resolve #1318 |
3 tasks
sayboras
force-pushed
the
feature/golang-1-15
branch
from
962738e to
3e4a868
Compare
Golang 1.15 comes to few improvements, one of them is to have smaller binary. This PR is to make golang 1.15 as default version in CI, I also update Docker based image to golang:1.15* as well. Two issues faced with golang 1.15: - Conflict between -v in `golangci-lint` and `go test`. Update to --verbose to avoid the same. - `nolintlint_unused.go` testdata is not matching regex. Correct by adding one space after // [1]: golang/go#40763 Signed-off-by: Tam Mach <sayboras@yahoo.com>
sayboras
force-pushed
the
feature/golang-1-15
branch
from
34bd373 to
12adeca
Compare
|
I wonder, shouldn't we also have the min Go version in |
Member
Author
Member
Author
|
For other reviewer, the failure in vulnerability scanner is not related to this PR. Will address seperately. |
Member
|
|
Member
Author
Yes, I did. I ran for cilium and k8s projects (as I have these two in my machine), details can be found in PR description. |
Member
|
Great, thank you @sayboras! |
denis-tingaikin
approved these changes
Aug 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binary is much smaller from 37MB to 31MB
Performance test
Please refer to the commit message for more details.
Signed-off-by: Tam Mach sayboras@yahoo.com