build(deps): bump honnef.co/go/tools from 0.6.1 to 0.7.0#6367
Conversation
Bumps [honnef.co/go/tools](https://github.com/dominikh/go-tools) from 0.6.1 to 0.7.0. - [Release notes](https://github.com/dominikh/go-tools/releases) - [Commits](dominikh/go-tools@v0.6.1...v0.7.0) --- updated-dependencies: - dependency-name: honnef.co/go/tools dependency-version: 0.7.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
0373042 to
ab1fcfb
Compare
|
There is problem, and for now, I don't find a solution. |
|
The problem only happens randomly inside some specific tests, when the cache is reused, and with multiple parallel runs. Inside the tests, we are using several tweaks, maybe this is related to that. I'm not able to reproduce the problem outside the tests. I think this is related to concurrent access to the cache of facts, on the same package but only in a specific context created during the tests. In all cases, the fact that a test is reusing the cache of the other tests is something that we should avoid because it breaks the expected isolation of each test. I modified the test framework to create an isolated cache for each tests. I will try to run it against several projects to confirm my idea. |
|
I tested the PR against several projects, several environment, and I'm not able to reproduce the problem. So, I think the problem is related to high level of stress (multiple configurations for the same package, parallelism, etc.) we put on the cache during the tests. I'm frustrating to not have the exact explanation of the behavior, I think this is a very specific edge case to our tests, but I need to move forward and merge the PR because it contains important changes for the go1.26 support. I hope my analysis is right, because it will be extremely difficult to rollback. |
Bumps honnef.co/go/tools from 0.6.1 to 0.7.0.
Release notes
Sourced from honnef.co/go/tools's releases.
... (truncated)
Commits
ff63afaVersion 2026.1 (v0.7.0)b4a35eaIgnore deprecated uses of GOROOT in our codead522a4config: add simd/archsimd to default dot_import_whitelist9bb55d1website: go mod tidy4d7b7cbwebsite: add 2026.1 release notes5b2cf0ago/ir, go/buildid: update UPSTREAM4e2a09aSA5008: update for latest version of encoding/json/v28be920fUpdate to Go 1.25 and run 'go fix'952cd74knowledge: update deprecations for Go 1.260ca3b12go/ir: support new(expr)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)