Skip to content

Commit d05e627

Browse files
saran-tcopybara-github
authored andcommitted
Enable back face culling in dm_control.viewer.
The viewer has its own set of default renderer flags, and when the `mjRND_CULL_FACE` flag was introduced in MuJoCo (google-deepmind/mujoco@396fdf0) the viewer's default was not updated. Fixes #346. PiperOrigin-RevId: 472753294 Change-Id: I33e6f48ff1ea887d07765ae851651f6c106cb08b
1 parent 60e18a5 commit d05e627

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

dm_control/mujoco/tutorial.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
" 'Go to the Runtime menu and select Choose runtime type.')\n",
7878
"\n",
7979
"print('Installing dm_control...')\n",
80-
"!pip install -q dm_control\u003e=1.0.6\n",
80+
"!pip install -q dm_control\u003e=1.0.7\n",
8181
"\n",
8282
"# Configure dm_control to use the EGL rendering backend (requires GPU)\n",
8383
"%env MUJOCO_GL=egl\n",

dm_control/viewer/renderer.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
_DEFAULT_RENDER_FLAGS[mujoco.mjtRndFlag.mjRND_SHADOW.value] = 1
4343
_DEFAULT_RENDER_FLAGS[mujoco.mjtRndFlag.mjRND_REFLECTION.value] = 1
4444
_DEFAULT_RENDER_FLAGS[mujoco.mjtRndFlag.mjRND_SKYBOX.value] = 1
45+
_DEFAULT_RENDER_FLAGS[mujoco.mjtRndFlag.mjRND_CULL_FACE.value] = 1
4546

4647

4748
class BaseRenderer(metaclass=abc.ABCMeta):

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def is_excluded(s):
173173

174174
setup(
175175
name='dm_control',
176-
version='1.0.6',
176+
version='1.0.7',
177177
description='Continuous control environments and MuJoCo Python bindings.',
178178
long_description="""
179179
# `dm_control`: DeepMind Infrastructure for Physics-Based Simulation.

tutorial.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
" 'Go to the Runtime menu and select Choose runtime type.')\n",
7878
"\n",
7979
"print('Installing dm_control...')\n",
80-
"!pip install -q dm_control\u003e=1.0.6\n",
80+
"!pip install -q dm_control\u003e=1.0.7\n",
8181
"\n",
8282
"# Configure dm_control to use the EGL rendering backend (requires GPU)\n",
8383
"%env MUJOCO_GL=egl\n",

0 commit comments

Comments
 (0)