Add support of ReAct and builtin planner #318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
force-pushed
the
feature/react-planner
branch
2 times, most recently
from
ad3f241 to
34737b6
Compare
git-hulk
force-pushed
the
feature/react-planner
branch
from
34737b6 to
20516e7
Compare
whoskavic
approved these changes
Nov 20, 2025
git-hulk
commented
Nov 20, 2025
verdverm
reviewed
Nov 21, 2025
| // | ||
| // Returns: | ||
| // The planning system instruction, or empty string if no instruction is needed. | ||
| BuildPlanningInstruction(readonlyContext agent.ReadonlyContext, llmRequest *model.LLMRequest) string |
There was a problem hiding this comment.
Is there a good reason to make this read only?
One thing we want to be able to do is pass around budget information to the instruction generation process. Having writable context would be helpful, otherwise we have to basically shim this entire process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ReAct and builtin planner for adk-go to align with adk-python.