Skip to content

Add support for an hidden_help attribute #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Oct 30, 2022

This PR allows hiding the help for some of the options.

It is based on #75, which is updated to match the latest changes.

Closes #73
Closes #75

@aminya aminya changed the title Add support for an hidden help attribute Add support for an hidden_help attribute Oct 30, 2022
Copy link
Collaborator

@sadmac7000 sadmac7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The total diff looks good, but I'd prefer it if you flattened the two "fix" commits into the original so we just had one commit.

@aminya
Copy link
Contributor Author

aminya commented Nov 3, 2022

You can squash the commits once you want to merge the pull request. This way, if the upstream doesn't care about the logic behind the changes, at least they are kept on my branch. My commits follow the atomic and semantic convention.

@sadmac7000 sadmac7000 merged commit 1dae49a into google:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow positional arguments to be omitted from the help text
2 participants