jsonclient: surface HTTP Do and Read errors #1695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Right now they are shadowed by the Close error. Note this from the net/http Client.Do docs, which allows simplifying the logic by far: > On error, any Response can be ignored. A non-nil Response with a > non-nil error only occurs when CheckRedirect fails, and even then the > returned [Response.Body] is already closed.
|
/gcbrun |
mhutchinson
approved these changes
May 6, 2025
mcpherrinm
added a commit
to letsencrypt/boulder
that referenced
this pull request
May 6, 2025
This updates to current `master`, bc7acd89f703743d050f5cd4a3b9746808e0fdae Notably, it includes a bug-fix to error handling in the HTTP client, which we found was hiding errors from CT logs, hindering our debugging. That fix is google/certificate-transparency-go#1695 No release has been tagged since this PR merged, so using the `master` commit. A few mutual dependencies used by both Boulder and ct-go are updated, including mysql, otel, and grpc.
aarongable
pushed a commit
to letsencrypt/boulder
that referenced
this pull request
May 6, 2025
This updates to current `master`, bc7acd89f703743d050f5cd4a3b9746808e0fdae Notably, it includes a bug-fix to error handling in the HTTP client, which we found was hiding errors from CT logs, hindering our debugging. That fix is google/certificate-transparency-go#1695 No release has been tagged since this PR merged, so using the `master` commit. A few mutual dependencies used by both Boulder and ct-go are updated, including mysql, otel, and grpc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now they are shadowed by the Close error.
Note this from the net/http Client.Do docs, which allows simplifying the
logic by far: