[CTFE] Configurable mechanism to rate-limit non-fresh submissions #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
/gcbrun |
mhutchinson
approved these changes
May 15, 2025
phbnf
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we've seen a lot of CT log growth due to one or more third parties bulk-submitting lots of "old" certificates that are presumably already present in multiple other logs. This DDoS vector has caused availability issues for some logs, affecting both the POST and GET endpoints. We need to be able to ensure that "old" submissions do not overwhelm a log's ability to (1) accept "fresh" submissions and (2) distribute them to monitors.
Over on the transparency-dev Slack, Matthew McPherrin suggested:
And Joe DeBlasio replied:
This PR implements this rate limiting strategy for CTFE.
Checklist