Skip to content

Make syntect fancy #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make syntect fancy #265

wants to merge 1 commit into from

Conversation

cuviper
Copy link

@cuviper cuviper commented Apr 30, 2025

This switches syntect from onig to fancy-regex for a pure Rust
implementation of regular expressions.

It's also worth noting that onig's underlying oniguruma library says
"This project ended on April 24, 2025", with its repo archived.

This switches `syntect` from `onig` to `fancy-regex` for a pure Rust
implementation of regular expressions.

It's also worth noting that `onig`'s underlying `oniguruma` library says
"This project ended on April 24, 2025", with its [repo archived][1].

[1]: https://github.com/kkos/oniguruma/
Copy link

google-cla bot commented Apr 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cuviper
Copy link
Author

cuviper commented Apr 30, 2025

I don't know that I care to deal with a CLA for such a small change. I welcome anyone else to recreate this, which should be trivial even without looking at my commit.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (886f15e) to head (16df8c1).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   84.74%   85.68%   +0.93%     
==========================================
  Files          15       17       +2     
  Lines        3377     3674     +297     
  Branches     3377     3674     +297     
==========================================
+ Hits         2862     3148     +286     
- Misses        413      423      +10     
- Partials      102      103       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgeisler
Copy link
Collaborator

mgeisler commented May 5, 2025

I don't know that I care to deal with a CLA for such a small change. I welcome anyone else to recreate this, which should be trivial even without looking at my commit.

Yeah, I understand completely! Sorry for the speed bump, it's a Google-wide policy to require an explicit signoff via the CLA.

I'll recreate it like you suggest. Thanks for the PR!

mgeisler added a commit that referenced this pull request May 5, 2025
This avoids a C dependency by switching to the pure Rust `regex`
crate.

Thanks @cuviper for suggesting this in #265.
@mgeisler mgeisler mentioned this pull request May 5, 2025
@mgeisler
Copy link
Collaborator

mgeisler commented May 5, 2025

#267 should do the same, thanks again!

@mgeisler mgeisler closed this May 5, 2025
mgeisler added a commit that referenced this pull request May 5, 2025
This avoids a C dependency by switching to the pure Rust `regex`
crate.

Thanks @cuviper for suggesting this in #265.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants