feat(storage): Adding support of single shot download #1493
+148
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
|
@shubham-up-47 Please add unit tests. |
chandra-siri
requested changes
Jun 19, 2025
| if self._single_shot_download: | ||
| # This is useful for smaller files, or when the user wants to | ||
| # download the entire file in one go. | ||
| content = response.content |
There was a problem hiding this comment.
Just a headsup : make sure this also works for objects with content-encoding:gzip and br
| if self._single_shot_download: | ||
| # This is useful for smaller files, or when the user wants to | ||
| # download the entire file in one go. | ||
| content = response.content |
There was a problem hiding this comment.
response.content will not download the entire file at once.
see response.content code which internally calls iter_content with CONTENT_CHUNK_SIZE (10KiB) little more than _SINGLE_GET_CHUNK_SIZE (8KiB).
that's the reason you're seeing only marginal improvement in download speed, from 123 -> 136
I suggest using response.raw.stream, response.raw will be urlib3's response object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the support of single shot download using a boolean flag.
Some results using the script in the customer issue,
Downloadspeed withsingle_shot_download=false(default value) = 123 MB / secDownloadspeed withsingle_shot_download=true= 136 MB / secRawDownloadspeed withsingle_shot_download=false(default value) = 131 MB / secRawDownloadspeed withsingle_shot_download=true= 289 MB / sec