Skip to content

Conversation

@chingor13
Copy link
Contributor

Fixes #483

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2020
@chingor13 chingor13 requested a review from a team April 13, 2020 22:30

env_vars: {
key: "GOOGLE_APPLICATION_CREDENTIALS"
value: "keystore/73713_java_it_service_account"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how keystore works. Does this service account include the permission to java-docs-samples-testing project? or Does this have to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does for some APIs which we will need to grant permissions for.

@chingor13 chingor13 merged commit 5263860 into googleapis:master Apr 13, 2020
@chingor13 chingor13 deleted the java-project branch April 13, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java: integration/sample tests should set GOOGLE_CLOUD_PROJECT

5 participants