This repository was archived by the owner on Dec 6, 2018. It is now read-only.
Change order of rotation to yaw and then pitch#256
Merged
lincolnfrog merged 1 commit intogooglearchive:masterfrom Oct 3, 2017
Merged
Change order of rotation to yaw and then pitch#256lincolnfrog merged 1 commit intogooglearchive:masterfrom
lincolnfrog merged 1 commit intogooglearchive:masterfrom
Conversation
THREE is using local axis to rotate using Euler and the order is 'XYZ' by default. Before this change, it would rotate around X first for "pitch" which would make local Y is than world Y, once it rotates around local "Y" for yaw the hotspot would end up being in the wrong place. This is not visible in the hotspots example as no pitch is set on any of the hotspots.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
Contributor
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THREE is using local axis to rotate using Euler and the order is 'XYZ'
by default. Before this change, it would rotate around X first for
"pitch" which would make local Y is than world Y, once it rotates around
local "Y" for yaw the hotspot would end up being in the wrong place.
This is not visible in the hotspots example as no pitch is set on any of
the hotspots.