Host header update#565
Merged
Merged
Conversation
ripienaar
reviewed
Apr 1, 2020
Contributor
Author
|
Confirmed tests pass, I think this is good to go. |
pedroMMM
approved these changes
Apr 5, 2020
Contributor
pedroMMM
left a comment
pedroMMM
left a comment
There was a problem hiding this comment.
@aelsabbahy it's ready for you.
aelsabbahy
requested changes
Apr 6, 2020
Member
aelsabbahy
left a comment
aelsabbahy
left a comment
There was a problem hiding this comment.
Small change requested.
Also, can you please update the docs to clarify that only the first Host: foo value is honored.
Aside from that, looks great!
Co-Authored-By: Ahmed Elsabbahy <aelsabbahy@users.noreply.github.com>
Contributor
Author
|
@aelsabbahy I made the documentation update, let me know what you think! |
aelsabbahy
approved these changes
Apr 8, 2020
Member
|
Looks great. There's going to be a bit of juggling with other PRs.. but I should have this merged/released in the next ~2weeks. |
Contributor
Author
|
@aelsabbahy awesome thanks! looking forward to it, this will allow me to implement a very helpful test :) |
Member
|
Awesome change, thank you! |
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* readme update * set host properly header if present * uncomment fix; add test * add back os lib * remove printing to stderr/stdout * rename host header test * rename other duplicate test * remove unneeded lib * update test counts * ninja markdown edit * Update system/http.go Co-Authored-By: Ahmed Elsabbahy <aelsabbahy@users.noreply.github.com> * add note about host header * Revert documentation change since it was fixed with goss-org#582 Co-authored-by: Ahmed Elsabbahy <aelsabbahy@users.noreply.github.com> Co-authored-by: Ahmed Elsabbahy <elsabbahyahmed@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Go's
httpignores/removes certain headers (n1, n2), including but not limited to theHostheader. See: github issue and go sourceThis change detects the presence of that header (or headers) and sets it on the http request.
Issue opened: #564
I also took the liberty of making a couple of unrelated changes: