Skip to content

Alpha test more quietly#631

Merged
aelsabbahy merged 3 commits into
goss-org:masterfrom
improbable-eng:alpha-quietly
Oct 19, 2020
Merged

Alpha test more quietly#631
aelsabbahy merged 3 commits into
goss-org:masterfrom
improbable-eng:alpha-quietly

Conversation

@petemounce
Copy link
Copy Markdown
Collaborator

@petemounce petemounce commented Oct 9, 2020

Fixes #629.

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

@aelsabbahy
Copy link
Copy Markdown
Member

What's this failure all about? ss command not found on windows?

@petemounce
Copy link
Copy Markdown
Collaborator Author

petemounce commented Oct 18, 2020

Yeah, ss doesn't appear to exist on Windows, so the command falls back to a random port selection. :(

I didn't find a similarly-fast way on Windows to find a randomly selected available port.

  • netstat -an too slow, tens of seconds
  • sysinternals tcpvcon -ac fast, doesn't include port like the GUI variant tcpview does 🤦

So, I wrote a piece of powershell and included it into this PR - hope the change is ok within this PR, but if not, happy to slice it to a different one? f01f093

…hree ways to bypass it, MOST OF THEM OUT OF THE BOX...
@petemounce
Copy link
Copy Markdown
Collaborator Author

I enjoyed cb7c137.

@aelsabbahy aelsabbahy merged commit 07b331c into goss-org:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing alpha warning when flag is set

2 participants