Skip to content

feat: Memcached: Add TLS support#12318

Merged
slim-bean merged 4 commits intomainfrom
use-dskit-cache
Mar 22, 2024
Merged

feat: Memcached: Add TLS support#12318
slim-bean merged 4 commits intomainfrom
use-dskit-cache

Conversation

@DylanGuedes
Copy link
Copy Markdown
Contributor

@DylanGuedes DylanGuedes commented Mar 22, 2024

What this PR does / why we need it:

  • Adds TLS support to our Memcached client
  • Expose new configs to configure memcache TLS

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@DylanGuedes DylanGuedes requested a review from a team as a code owner March 22, 2024 12:20
@DylanGuedes DylanGuedes changed the title Memcached: Add TLS support feat: Memcached: Add TLS support Mar 22, 2024
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Mar 22, 2024
@github-actions github-actions Bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 22, 2024
slim-bean
slim-bean approved these changes Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slim-bean slim-bean merged commit 51c54ad into main Mar 22, 2024
@slim-bean slim-bean deleted the use-dskit-cache branch March 22, 2024 18:00
@loki-gh-app loki-gh-app Bot mentioned this pull request Mar 27, 2024
Closed
@joe-elliott joe-elliott mentioned this pull request Apr 11, 2024
Closed
@sonisr sonisr mentioned this pull request Apr 17, 2024
Merged
3 tasks
@loki-gh-app loki-gh-app Bot mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees

No one assigned

Labels

size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DylanGuedes @slim-bean