Reload search blocks and replay search WAL#1000
Merged
mdisibio merged 23 commits intografana:mainfrom Oct 6, 2021
Merged
Conversation
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Collaborator
|
PR #1000! |
mdisibio
reviewed
Sep 30, 2021
mdisibio
reviewed
Sep 30, 2021
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
annanay25
requested review from
dgzlopes,
joe-elliott,
mapno and
yvrhdn
as code owners
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
12 tasks
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
mdisibio
reviewed
Oct 1, 2021
mdisibio
reviewed
Oct 1, 2021
mdisibio
reviewed
Oct 1, 2021
mdisibio
reviewed
Oct 1, 2021
mdisibio
reviewed
Oct 1, 2021
mdisibio
reviewed
Oct 1, 2021
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Very close to LGTM. Left a few comments.
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Martin Disibio <mdisibio@gmail.com>
…lock encoding Signed-off-by: Martin Disibio <mdisibio@gmail.com>
…lock encoding Signed-off-by: Martin Disibio <mdisibio@gmail.com>
…essary Signed-off-by: Martin Disibio <mdisibio@gmail.com>
Signed-off-by: Martin Disibio <mdisibio@gmail.com>
mdisibio
approved these changes
Oct 5, 2021
zalegrala
reviewed
Oct 5, 2021
Signed-off-by: Martin Disibio <mdisibio@gmail.com>
Signed-off-by: Martin Disibio <mdisibio@gmail.com>
Signed-off-by: Martin Disibio <mdisibio@gmail.com>
joe-elliott
approved these changes
Oct 6, 2021
annanay25
commented
Oct 11, 2021
| require.NoError(t, err) | ||
| } | ||
|
|
||
| func TestParseFileName(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
We had a test for ParseFileName in append_block_test.go. But no worries, we can club the two in a later PR
annanay25
commented
Oct 11, 2021
|
|
||
| } | ||
|
|
||
| func BenchmarkBackendSearchBlockSearch(b *testing.B) { |
Contributor
Author
There was a problem hiding this comment.
@mdisibio did you intend to relocate this test as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
StreamingSearchBlock. See benchmark numbers below for each encoding/compression format.BackendSearchBlocksAppendBlockandStreamingSearchBlockalso
Which issue(s) this PR fixes:
Fixes part of #932
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]