Skip to content

Upgrade to jsonnet-libs 1.19 and update tk examples#1001

Merged
mapno merged 3 commits intografana:mainfrom
mapno:update-jsonnet
Oct 4, 2021
Merged

Upgrade to jsonnet-libs 1.19 and update tk examples#1001
mapno merged 3 commits intografana:mainfrom
mapno:update-jsonnet

Conversation

@mapno
Copy link
Copy Markdown
Contributor

@mapno mapno commented Sep 30, 2021

What this PR does:

Upgrade jsonnet-libs to 1.19 and update tk examples.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mapno mapno changed the title Upgrade jsonnet-libs to 1.19 and update tk examples Upgrade to jsonnet-libs 1.19 and update tk examples Sep 30, 2021
@joe-elliott joe-elliott self-assigned this Sep 30, 2021
Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both single-binary and microservices.

Any idea why it added a billion new files?

@yvrhdn
Copy link
Copy Markdown
Contributor

yvrhdn commented Oct 1, 2021

This PR changes a dependency from https://github.com/ksonnet/ksonnet-lib to https://github.com/jsonnet-libs/k8s-libsonnet. So vendoring has to replace an entire repo.

Comment thread CHANGELOG.md Outdated
mapno and others added 2 commits October 4, 2021 11:00
Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
@mapno mapno merged commit 44cbb18 into grafana:main Oct 4, 2021
@mapno mapno deleted the update-jsonnet branch October 4, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants