Merged
Conversation
mapno
requested review from
annanay25,
dgzlopes,
joe-elliott,
mdisibio and
yvrhdn
as code owners
mapno
force-pushed
the
block-partial-results
branch
from
9f6bbe7 to
ddb78ad
Compare
mapno
commented
Oct 5, 2021
joe-elliott
reviewed
Oct 6, 2021
joe-elliott
previously approved these changes
Oct 7, 2021
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
couple of nits, but looks good!
merge when you're ready
joe-elliott
reviewed
Oct 7, 2021
joe-elliott
approved these changes
Oct 8, 2021
annanay25
reviewed
Oct 11, 2021
| "github.com/cortexproject/cortex/pkg/ring" | ||
| ring_client "github.com/cortexproject/cortex/pkg/ring/client" | ||
| "github.com/cortexproject/cortex/pkg/util/log" | ||
| "github.com/go-kit/log/level" |
Contributor
There was a problem hiding this comment.
This is a different level package from what we use: github.com/go-kit/kit/log/level
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It supports partial results when block queries fail.
The general idea is to let queriers fail when querying blocks and decide the query frontend if the errors are too many or if the partial result is worth returning.
Partial results are indicated with http 206 (partial content).
Superseeds #988.
Which issue(s) this PR fixes:
Contributes to #899
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]