Buffer WAL writes#1018
Merged
joe-elliott merged 17 commits intografana:mainfrom Oct 9, 2021
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
KMiller-Grafana,
annanay25,
dgzlopes,
mapno,
mdisibio and
yvrhdn
as code owners
zalegrala
reviewed
Oct 8, 2021
| // blockID, tenantID, version, encoding (compression), dataEncoding | ||
| filename := fmt.Sprintf("%v:%v:%v:%v:%v", blockid, tenantid, "v2", backend.EncNone, "") | ||
| return os.OpenFile(filepath.Join(p, filename), os.O_CREATE|os.O_RDWR, 0644) | ||
| file, err := os.OpenFile(filepath.Join(p, filename), os.O_CREATE|os.O_RDWR, 0644) |
zalegrala
approved these changes
Oct 8, 2021
KMiller-Grafana
approved these changes
Oct 8, 2021
Contributor
KMiller-Grafana
left a comment
KMiller-Grafana
left a comment
There was a problem hiding this comment.
Docs portion of this PR looks good to me.
mdisibio
approved these changes
Oct 8, 2021
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
LGTM. Method renames are great. Left a few small questions, not-blocking.
joe-elliott
added a commit
to joe-elliott/tempo
that referenced
this pull request
Oct 19, 2021
This reverts commit 2ff99b6.
joe-elliott
added a commit
that referenced
this pull request
Oct 19, 2021
* Revert "Buffer WAL writes (#1018)" This reverts commit 2ff99b6. * Write->Append Signed-off-by: Joe Elliott <number101010@gmail.com> * restored manifest changes Signed-off-by: Joe Elliott <number101010@gmail.com> * put search_encoding back Signed-off-by: Joe Elliott <number101010@gmail.com> * GetIterator -> Iterator Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * assert => require Signed-off-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Buffers wal writes using a bufio.Writer. Adds a configurable buffer size that defaults to 1MB.
Early testing looks good, but I'm still gathering evidence that it is a positive change. Marked draft for now.Draft dropped. Avg working set of ingesters much lower since the change:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]