[DOCUMENTATION] Add line to show that grpc_server_max_send_msg_size is configurable a…#1023
Merged
annanay25 merged 2 commits intografana:mainfrom Oct 14, 2021
Conversation
…nd add language to explain when you might need to modify it
joe-elliott
approved these changes
Oct 12, 2021
KMiller-Grafana
approved these changes
Oct 12, 2021
Contributor
KMiller-Grafana
left a comment
There was a problem hiding this comment.
I approve of the docs change, but wish that you'd add the units to description for both the recv and send message size.
It'd read something like
Max gRPC message size in bytes that can be received
Contributor
|
Oops! I didn't see the comment from Karen. Will add in a follow up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd add language to explain when you might need to modify it
What this PR does:

I ran into this issue when trying to view a large trace from Loki (25k spans).
I was able to get past the issue by increasing
server. grpc_server_max_recv_msg_sizefrom4194304to104857600.I exchanged messages with @kvrhdn and he pointed out that the
ingester_clientconfigured in thequerieris instantiated with a message send size much higher than the default message receive max size used by the ingester.Which issue(s) this PR fixes:
I didn't get all the way to a Github Issue, but I dropped this message in the Tempo slack.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]