Search: drop use of TagCache, extract tags and tag values on-demand#1068
Search: drop use of TagCache, extract tags and tag values on-demand#1068annanay25 merged 30 commits intografana:mainfrom
Conversation
|
I've been doing a test on my local set up fetching tag values for Avg latency sits around 200-400 ms. |
… of data from flatbuffers. Add new FindTag function
Drop tag cache 2
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
|
Still to address: when fetching tag values with very high cardinality (for instance Future improvements (not for this PR): we can add filter capabilities to the tag values endpoint, so if someone starts typing |
joe-elliott
left a comment
There was a problem hiding this comment.
Remove the TagCache struct?
Yep 👍, I've removed |
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
f76ea92 to
f7e95f0
Compare
mdisibio
left a comment
There was a problem hiding this comment.
Thanks for getting the limit check in. Good to merge.
Signed-off-by: Annanay <annanayagarwal@gmail.com>
22739f1 to
535263c
Compare
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>

What this PR does:
Instead of storing tags and tag values in the TagCache we can extract them directly from live traces, WAL and local blocks when requested. This should lower the amount of work spent on updating the tagcache during ingest.
Since tag values are extracted on-demand, we are not limited anymore by the size of the tag cache. So this makes it possible to return thousands of values when needed.
Which issue(s) this PR fixes:
Fixes #Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]