Support error and status.code searches#1093
Merged
mdisibio merged 6 commits intografana:mainfrom Nov 2, 2021
Merged
Conversation
mdisibio
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno and
yvrhdn
as code owners
12 tasks
yvrhdn
reviewed
Nov 2, 2021
Contributor
yvrhdn
left a comment
yvrhdn
left a comment
There was a problem hiding this comment.
Left some comments/concerns, but overall this is really nice work. I like the concept of virtual tags to match the model Grafana uses when displaying the trace.
Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
yvrhdn
approved these changes
Nov 2, 2021
Contributor
yvrhdn
left a comment
yvrhdn
left a comment
There was a problem hiding this comment.
Besides a possible simplification this looks good to me 👍
I like how this turned out, with the virtual tags and values we don't have to muck with the actual ingested data 😌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds support for searching on span status. Raw span status in OTLP is an integer, and this is recorded as the new tag
status.code=<int>(this matches the way Grafana already displays this data). This can be searched directly, or via the following more user-friendly methods:status.code=unset|ok|error- The search pipeline will rewrite the text versions into a lookup for the corresponding integer. The tag name/value lookup apis will return these user-friendly texts and not the integers.error=true|false- A new virtual "error" tag can be searched that is rewritten into a lookup on status.code integer. Similarly, the tag name/value lookup apis will return this tag and the two values.Which issue(s) this PR fixes:
Fixes part of #932
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]