Skip to content

Add jsonnet lib for Grafana Enterprise Traces#1096

Merged
joe-elliott merged 1 commit intomainfrom
chaudum/enterprise-jsonnet
Nov 5, 2021
Merged

Add jsonnet lib for Grafana Enterprise Traces#1096
joe-elliott merged 1 commit intomainfrom
chaudum/enterprise-jsonnet

Conversation

@chaudum
Copy link
Copy Markdown
Contributor

@chaudum chaudum commented Nov 3, 2021

What this PR does:

This PR adds a jsonnet library for Grafana Enterprise Traces.

Closes https://github.com/grafana/backend-enterprise/issues/2593

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@chaudum chaudum force-pushed the chaudum/enterprise-jsonnet branch from fbdcdf7 to c43c883 Compare November 3, 2021 08:38
chaudum added a commit that referenced this pull request Nov 3, 2021
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum marked this pull request as ready for review November 3, 2021 10:09
Copy link
Copy Markdown
Contributor

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>

Add simple verification tooling for GET jsonnet lib

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>

Add changelog entry for #1096

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/enterprise-jsonnet branch from d365c70 to e8384f4 Compare November 3, 2021 14:52
@chaudum
Copy link
Copy Markdown
Contributor Author

chaudum commented Nov 4, 2021

@joe-elliott Is the failing test a know flaky test? Could you please merge this PR as I do not have permissions to do so?

@joe-elliott joe-elliott merged commit bde7d6d into main Nov 5, 2021
@joe-elliott joe-elliott deleted the chaudum/enterprise-jsonnet branch November 5, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants