Merged
Conversation
mapno
requested review from
annanay25,
dgzlopes,
joe-elliott,
mdisibio and
yvrhdn
as code owners
mdisibio
approved these changes
Dec 1, 2021
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Nice addition, should be very helpful for compactor scaling and troubleshooting.
joe-elliott
reviewed
Dec 1, 2021
mapno
force-pushed
the
compaction-load-metric
branch
from
5191b1a to
bbb0571
Compare
joe-elliott
reviewed
Dec 2, 2021
| rw.blocklist.Update(tenantID, newBlocks, oldBlocks, newCompactions) | ||
| } | ||
|
|
||
| func measureOutstandingBlocks(tenantID string, blockSelector CompactionBlockSelector) { |
Collaborator
There was a problem hiding this comment.
+1 moving this into its own method. cleans up doCompaction() nicely
joe-elliott
approved these changes
Dec 2, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds new metric to measure compaction load. It counts the number of blocks that are yet to be compacted before the next maintenance cycle. It's higher, the greater the compaction load is.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]