Improve compaction efficiency#1145
Merged
joe-elliott merged 6 commits intografana:mainfrom Dec 2, 2021
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
dgzlopes,
mapno,
mdisibio and
yvrhdn
as code owners
Signed-off-by: Joe Elliott <number101010@gmail.com>
KMiller-Grafana
approved these changes
Dec 1, 2021
Contributor
KMiller-Grafana
left a comment
KMiller-Grafana
left a comment
There was a problem hiding this comment.
Docs portion of this PR looks good to me.
Signed-off-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
In multitenant environments tenants with long blocklists can be starved of work from the compactors. This is in part due to the compactionCycle wait time. Reducing this hardcoded value to improve the rate at which a compactor will move through all tenants.
compactionCycleto delay just enough to prevent a tight loop that eats CPU for no reason.waitOnStartupto account for the loss of 30s in the compactionCycle. This might not be necessary but making the change to reduce the impact of this PR.max_compaction_cyclethat allows the polling cycle and the compaction cycle to be independently configured.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]