Update mixin to use new backend metric#1151
Merged
yvrhdn merged 3 commits intografana:mainfrom Dec 2, 2021
Merged
Conversation
zalegrala
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
mdisibio and
yvrhdn
as code owners
zalegrala
changed the title
zalegrala
force-pushed
the
backendMetric
branch
from
ba095ac to
7f5d032
Compare
yvrhdn
reviewed
Dec 2, 2021
Contributor
yvrhdn
left a comment
yvrhdn
left a comment
There was a problem hiding this comment.
Looks good to me, just a small comment. Btw, you've only changed the tempo-mixin right? The PR mentions "examples and dashboards", are you also planning to update the examples?
Do they even use this metric?
| @@ -67,11 +67,11 @@ dashboard_utils { | |||
| g.row('GCS') | |||
Contributor
There was a problem hiding this comment.
Can you also change the name of these rows? There are a couple references to GCS in these dashboards.
Contributor
Author
|
You're right, I'll update the commit. I think before I'd rebased there were changes elsewhere. |
zalegrala
force-pushed
the
backendMetric
branch
from
7f5d032 to
6b71021
Compare
zalegrala
changed the title
zalegrala
force-pushed
the
backendMetric
branch
2 times, most recently
from
975c847 to
ab80def
Compare
zalegrala
force-pushed
the
backendMetric
branch
from
ab80def to
aa3c403
Compare
zalegrala
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]