Update hedgedhttp to v0.7.0#1159
Merged
annanay25 merged 4 commits intografana:mainfrom Dec 14, 2021
Merged
Conversation
cristaloleg
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
mdisibio and
yvrhdn
as code owners
|
|
annanay25
approved these changes
Dec 8, 2021
Contributor
annanay25
left a comment
annanay25
left a comment
There was a problem hiding this comment.
LGTM, thanks @cristaloleg.
Contributor
Author
|
Not sure about a failure regarding gRPC and spans, seems unrelated https://github.com/grafana/tempo/runs/4455346789?check_suite_focus=true |
Contributor
|
Yeah sorry this is one of our flaky tests. Your changes are good, I'll ping you on this PR once the fix is merged and we can rebase? |
Contributor
Author
|
Yeah, sure |
Contributor
|
Hi @cristaloleg, sorry for the delay. We've merged a few integration test fixes. Can you rebase this over |
cristaloleg
force-pushed
the
update-hedgedhttp
branch
from
1e7c8ab to
a24af56
Compare
Contributor
Author
|
Done, waiting for CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
In github.com/cristalhq/hedgedhttp v0.7.0 there was a breaking change: error is returned during client/rounttripper creation instead of a panic, this PR updates it. Sorry for a change, but this is better.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]