Skip to content

Backend Search#1174

Merged
joe-elliott merged 31 commits intografana:mainfrom
joe-elliott:backend-search-letsgo
Dec 16, 2021
Merged

Backend Search#1174
joe-elliott merged 31 commits intografana:mainfrom
joe-elliott:backend-search-letsgo

Conversation

@joe-elliott
Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott commented Dec 13, 2021

What this PR does:
Adds support for full backend search to the /api/search endpoint. If parameters start and end are provided Tempo will perform a full backend search by scanning the blocks in parallel. This PR also includes code to run and configuration to use a Google Cloud Function to perform the scanning of blocks.

Changes:

  • Additional query-frontend params related to search. default_result_limit and max_result_limit were moved from the querier config to here:
query_frontend:
  search:
    concurrent_jobs: <int>
    target_bytes_per_job: <int>
    default_result_limit: <int>
    max_result_limit: <int>
    max_duration: <duration>
    query_ingesters_within_min: <duration>
    query_ingesters_within_max: <duration>
  • Additional storage parameters related to search:
storage:
  trace:
    search:
      chunk_size_bytes: <int>
      prefetch_trace_count: <int>
  • Full Backend and Serverless integration tests
  • Fixes on some flakey integration tests by using cortex_e2e.WaitMissingMetrics
  • Testing on model.Matches()

Which issue(s) this PR fixes:
Fixes #1112

Even though we are clearing #1112 as part of this PR backend search is far from complete. A new issue will be created "Backend search production readiness" (#1175) that will track future search work.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott and others added 7 commits December 13, 2021 11:23
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Comment thread tempodb/tempodb.go
Comment thread modules/frontend/config.go Outdated
Comment thread modules/frontend/searchsharding.go
Comment thread modules/frontend/searchsharding.go Outdated
Comment thread modules/frontend/searchsharding.go Outdated
Copy link
Copy Markdown
Contributor

@yvrhdn yvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work consolidating all those search functions!

Comment thread integration/e2e/serverless_test.go Outdated
Comment thread modules/frontend/frontend.go Outdated
Comment thread pkg/tempopb/tempo.proto
Comment thread docs/tempo/website/configuration/_index.md Outdated
Comment thread modules/frontend/searchsharding.go Outdated
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Copy link
Copy Markdown
Contributor

@mdisibio mdisibio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Backend Search

3 participants