Ingester prevent writes to large traces even after flushing#1199
Merged
mdisibio merged 5 commits intografana:mainfrom Jan 5, 2022
Merged
Ingester prevent writes to large traces even after flushing#1199mdisibio merged 5 commits intografana:mainfrom
mdisibio merged 5 commits intografana:mainfrom
Conversation
…ing to disk, keep rejecting writes until reset when cutting block
mdisibio
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
yvrhdn and
zalegrala
as code owners
joe-elliott
approved these changes
Jan 4, 2022
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
minor thoughts. lgtm
annanay25
reviewed
Jan 5, 2022
| * [BUGFIX] Ensure that the admin client jsonnet has correct S3 bucket property. (@hedss) | ||
| * [BUGFIX] Publish tenant index age correctly for tenant index writers. [#1146](https://github.com/grafana/tempo/pull/1146) (@joe-elliott) | ||
| * [BUGFIX] Ingester startup panic `slice bounds out of range` [#1195](https://github.com/grafana/tempo/issues/1195) (@mdisibio) | ||
| * [BUGFIX] Prevent writes to large traces even after flushing to disk [#1199](https://github.com/grafana/tempo/pull/1199) (@mdisibio) |
Contributor
There was a problem hiding this comment.
I think another solution that might cover more cases is returning an error from CombineTraces() as soon as the pieces sum up to > maxbytes. That will help fix compaction as well as querying.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR updates the ingester to keep track of traces that exceeded max size and reject further writes to them, even after they are flushed to disk. The list of traces is reset when cutting the head block.
Which issue(s) this PR fixes:
Fixes part of #1133
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]