Enterprise jsonnet: add config to create tokengen job explicitly#1256
Merged
yvrhdn merged 3 commits intografana:mainfrom Jan 28, 2022
Merged
Conversation
yvrhdn
changed the title
yvrhdn
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
mdisibio and
zalegrala
as code owners
joe-elliott
approved these changes
Jan 28, 2022
hedss
approved these changes
Jan 28, 2022
Contributor
hedss
left a comment
hedss
left a comment
There was a problem hiding this comment.
Perfect! Thank you for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
The jsonnet for GET creates a job to generate the token from a GET license (
tokengen). This job should be created once when installing GET and the job can not be modified afterwards. To make this easier to manage, this PR adds a config optionrun_tokengen_jobwhich is disabled by default and can be set to explicitly create the tokengen job.How it works:
The first time a GET cluster is created the user should set:
During
tk apply, tanka will create the tokengen job (just like before). After the job has run, the user should remove this line and the tokengen job will not be modified anymore by tanka.Which issue(s) this PR fixes:
Fixes #Checklist
Tests updatedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]