Add new alerts to the tempo-mixin#1292
Merged
mapno merged 2 commits intografana:mainfrom Feb 21, 2022
Merged
Conversation
Alerts added: - TempoBadOverrides - TempoProvisioningTooManyWrites - TempoCompactorsTooManyOutstandingBlocks
mapno
requested review from
annanay25,
dgzlopes,
joe-elliott,
mdisibio,
yvrhdn and
zalegrala
as code owners
zalegrala
reviewed
Feb 18, 2022
| { | ||
| alert: 'TempoBadOverrides', | ||
| expr: ||| | ||
| sum(tempo_runtime_config_last_reload_successful{namespace=~"%s"} == 0) by (cluster, namespace, job) |
Contributor
There was a problem hiding this comment.
Does this metric increase even if the overrides config does not change?
Contributor
Author
There was a problem hiding this comment.
Yes. dskit doesn't even seem to check if the config has changed or not: https://github.com/grafana/dskit/blob/main/runtimeconfig/manager.go#L145-L170
zalegrala
approved these changes
Feb 18, 2022
Contributor
zalegrala
left a comment
zalegrala
left a comment
There was a problem hiding this comment.
Looks reasonable to me. Just one question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds new alerts to the tempo-mixin.
TempoProvisioningTooManyWrites: measures number of writes to ingesters stays below a defined target (30MB/s per ingester).TempoCompactorsTooManyOutstandingBlocks: measures that the number of blocks pending to be compacted does not go above a target.TempoBadOverrides: monitors failed override reloads.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]