Merged
Conversation
joe-elliott
reviewed
Mar 8, 2022
Collaborator
joe-elliott
left a comment
There was a problem hiding this comment.
This just changes our CI pipeline right? Should we update the docker image that we build off as well?
Contributor
Author
|
I updated the lambda Dockerfile Go version, and also the alpine version. Did I miss any others? Let's see if CI passes with the new alpine. |
Contributor
|
Fwiw it looks like the floating And to be sure, my local go is only .6: |
Contributor
Author
|
I suppose as long as the release builds are happening with the new version, I'm fine leaving out the patch pinning here. What do we think about the alpine updates? |
Collaborator
|
my .02:
@zalegrala remove the go changes and we'll merge? |
joe-elliott
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we update Go in our CI to address a potential security issue in one
of our dependencies.
https://groups.google.com/g/golang-announce/c/RP1hfrBYVuk/m/I7ouYouLAAAJ
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]