Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
KMiller-Grafana,
annanay25,
dgzlopes,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
Collaborator
Author
|
Threw this together while moving around between locations. It likely needs a closer look than my normal flawless PRs ;) |
Signed-off-by: Joe Elliott <number101010@gmail.com>
mdisibio
approved these changes
Mar 29, 2022
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
LGTM. Noted a few cosmetic things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Moves external endpoint hedged search options from the query frontend to the querier. These options were taking into account queue time on the query frontend and were difficult to balance against other options. They are much more effective in the querier.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]