Per tenant max search duration#1421
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
KMiller-Grafana,
annanay25,
dgzlopes,
knylander-grafana,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Reviewed the doc files and have a few minor suggestions. "Config" was changed to configuration so it's spelled out. Front-end component is a compound adjective so should be hyphenated.
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for making the suggested changes. I'll use Comment instead next time.
Signed-off-by: Joe Elliott <number101010@gmail.com>
| MaxBytesPerTagValuesQuery int `yaml:"max_bytes_per_tag_values_query" json:"max_bytes_per_tag_values_query"` | ||
|
|
||
| // QueryFrontend enforced limits | ||
| MaxSearchDuration model.Duration `yaml:"max_search_duration" json:"max_search_duration"` |
There was a problem hiding this comment.
Is there a reason for model.Duration? Just comparing to MetricsGeneratorCollectionInterval time.Duration above.
There was a problem hiding this comment.
I think we use model.Duration b/c it supports marshalling to and from JSON as well as YAML whereas time.Duration seems to only support YAML. There are 3 model.Duration fields and only 1 time.Duration.
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
LGTM just one question.
3 participants
What this PR does:
Adds the ability to have a per tenant max search duration. By default, if there is no per tenant configuration, the original config value is used. This PR also updates the jsonnet under
./operationsto mount the overrides yaml onto the frontend.Additional changes
block_retentionoverrideChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]