Include rollout dashboard, borrowed from Mimir#1456
Merged
zalegrala merged 5 commits intografana:mainfrom Jun 2, 2022
Merged
Conversation
zalegrala
force-pushed
the
mixinRolloutDashboard
branch
2 times, most recently
from
afc8ea8 to
5eb14fd
Compare
zalegrala
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
mdisibio and
yvrhdn
as code owners
zalegrala
force-pushed
the
mixinRolloutDashboard
branch
2 times, most recently
from
862fcec to
b9266f4
Compare
joe-elliott
reviewed
Jun 1, 2022
| // | ||
| $.panel('Writes - 2xx') + | ||
| $.newStatPanel(||| | ||
| sum(rate(cortex_request_duration_seconds_count{%(gateway_job_matcher)s, route=~"%(gateway_write_routes_regex)s",status_code=~"2.+"}[$__rate_interval])) / |
Collaborator
There was a problem hiding this comment.
I think all these cortex_ metrics should be tempo_ metrics? Double check by importing the dashboard into an env that has tempo to make sure these graphs are populated.
| namespace_matcher: $.namespaceMatcher(), | ||
| per_cluster_label: $._config.per_cluster_label, | ||
| gateway_job_matcher: $.jobMatcher($._config.jobs.gateway), | ||
| gateway_write_routes_regex: 'api_(v1|prom)_push', |
Collaborator
There was a problem hiding this comment.
i don't think these read/write routes will work for us.
annanay25
approved these changes
Jun 1, 2022
zalegrala
force-pushed
the
mixinRolloutDashboard
branch
from
b9266f4 to
78aadba
Compare
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
tempo-mixinChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]