Update tempo microservices Helm values example which missed the 'enabled' key for thriftHttp#1472
Merged
zalegrala merged 4 commits intografana:mainfrom Jun 2, 2022
hajowieland:fix/example-tempo-microservices-values
Merged
Update tempo microservices Helm values example which missed the 'enabled' key for thriftHttp#1472zalegrala merged 4 commits intografana:mainfrom hajowieland:fix/example-tempo-microservices-values
zalegrala merged 4 commits intografana:mainfrom
hajowieland:fix/example-tempo-microservices-values
Conversation
… Helm values example
hajowieland
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
|
|
zalegrala
approved these changes
Jun 2, 2022
Contributor
zalegrala
left a comment
zalegrala
left a comment
There was a problem hiding this comment.
Thank you for the contribution. This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds missing
enabledYAML key in microservices-tempo-values for thriftHttp causing Helm deployment to fail.Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]