Google Cloud Run is the new Cloud Functions#1483
Merged
joe-elliott merged 8 commits intografana:mainfrom Jun 13, 2022
Merged
Conversation
joe-elliott
requested review from
annanay25,
dgzlopes,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
annanay25
reviewed
Jun 10, 2022
mdisibio
reviewed
Jun 10, 2022
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
KMiller-Grafana and
knylander-grafana
as code owners
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
zalegrala
reviewed
Jun 10, 2022
| @@ -0,0 +1,147 @@ | |||
| module github.com/grafana/tempo/cmd/tempo-serverless/cloud-run | |||
|
|
|||
| go 1.18 | |||
Collaborator
Author
There was a problem hiding this comment.
I'm actually going to walk this back to 1.17 to match the rest of the codebase. We should move this forward together.
zalegrala
reviewed
Jun 10, 2022
| # build the serverless container image | ||
| # | ||
| # todo: FROM scratch saves ~5MB which could be meaningful in a serverless setting, but using scratch gave strange errors on query. | ||
| FROM alpine:3.15 as certs |
Contributor
There was a problem hiding this comment.
I think 3.16 is out if you want to upgrade.
Collaborator
Author
There was a problem hiding this comment.
Not a bad idea, but all other images are on 3.15. I'm going to leave this on 3.15 as well. We should open a separate PR that moves all of them forward as one.
zalegrala
approved these changes
Jun 10, 2022
Contributor
zalegrala
left a comment
zalegrala
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for putting it together.
Signed-off-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes Tempo's GCP serverless technology from Function to Run. Google Cloud Run supports generic container images and allows us to use Go 1.18 for Parquet support.
Changes made:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]