Implement configuration option for the querier to only hit the ingesters based on the trace id hashes instead of all healthy ingesters#1484
Merged
joe-elliott merged 10 commits intografana:mainfrom Jun 13, 2022
Conversation
…t setups (grafana#1417) * metrics-generator: don't inject X-Scope-OrgID header for single-tenant setups * Update CHANGELOG.md
…t honoring max_bytes_per_trace (grafana#1420) * Fix compactor to record compaction_objects_combined_total and honor max_bytes_per_trace again * changelog
…grafana#1422) * distributor: prevent panics when concurrently calling to forwarder's queueManager * Update PR number * Pin k6 version to v0.37.0
sagarwala
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
sagarwala
requested review from
KMiller-Grafana and
knylander-grafana
as code owners
joe-elliott
reviewed
Jun 10, 2022
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Change looks good. Had a few comments and suggestions.
Contributor
Author
|
Thank you @joe-elliott . I have updated the PR as per the comments. I am using |
joe-elliott
approved these changes
Jun 13, 2022
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Nice addition. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implement configuration option for the querier to only hit the ingesters based on the trace id hashes instead of all healthy ingesters
Which issue(s) this PR fixes:
Fixes #1477
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]