Skip to content

Adding Blocklist backend metrics#1519

Merged
joe-elliott merged 3 commits intografana:mainfrom
ie-pham:jennie/1502
Jun 30, 2022
Merged

Adding Blocklist backend metrics#1519
joe-elliott merged 3 commits intografana:mainfrom
ie-pham:jennie/1502

Conversation

@ie-pham
Copy link
Copy Markdown
Contributor

@ie-pham ie-pham commented Jun 28, 2022

What this PR does:
This adds additional blocklist backend metrics as mentioned in #1502 which are total backend objects and total backend bytes.

Which issue(s) this PR fixes:
Fixes #1502

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 28, 2022

CLA assistant check
All committers have signed the CLA.

@ie-pham ie-pham marked this pull request as ready for review June 28, 2022 20:35
Copy link
Copy Markdown
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ie-pham! Happy to see your PR 🚀

Comment thread CHANGELOG.md Outdated
Comment thread tempodb/blocklist/poller_test.go Outdated
Comment thread tempodb/blocklist/poller.go Outdated
Comment thread tempodb/blocklist/poller.go Outdated
Comment thread tempodb/blocklist/poller.go Outdated
@ie-pham ie-pham requested review from annanay25 and joe-elliott June 30, 2022 18:51
Comment thread tempodb/blocklist/poller.go Outdated
@ie-pham ie-pham requested a review from joe-elliott June 30, 2022 19:51
Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go!

@joe-elliott joe-elliott merged commit ff9f798 into grafana:main Jun 30, 2022
joe-elliott pushed a commit to joe-elliott/tempo that referenced this pull request Jul 7, 2022
* Adding Blocklist backend metrics

* refactoring function to return struct

* changing total bytes variables back to uint64

Co-authored-by: Jennie Pham <jenniepham@Jennies-MBP.attlocal.net>
@ie-pham ie-pham deleted the jennie/1502 branch March 17, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more blocklist metrics

4 participants