Add ephemeral storage to generator for wal storage#1556
Merged
zalegrala merged 8 commits intografana:mainfrom Jul 14, 2022
Merged
Add ephemeral storage to generator for wal storage#1556zalegrala merged 8 commits intografana:mainfrom
zalegrala merged 8 commits intografana:mainfrom
Conversation
annanay25
reviewed
Jul 8, 2022
zalegrala
force-pushed
the
generatorWalPvc
branch
2 times, most recently
from
8fa6110 to
973b065
Compare
annanay25
reviewed
Jul 11, 2022
zalegrala
force-pushed
the
generatorWalPvc
branch
from
b3532b3 to
c827a7a
Compare
zalegrala
changed the title
Contributor
Author
|
I've made an update here to include an emptyDir and request limits. Let me know your thoughts. |
zalegrala
requested review from
joe-elliott,
mapno,
mdisibio and
yvrhdn
as code owners
zalegrala
force-pushed
the
generatorWalPvc
branch
from
73a3f35 to
2aac204
Compare
zalegrala
force-pushed
the
generatorWalPvc
branch
from
2aac204 to
efce027
Compare
zalegrala
force-pushed
the
generatorWalPvc
branch
from
5ca3420 to
0062f93
Compare
zalegrala
commented
Jul 12, 2022
annanay25
reviewed
Jul 13, 2022
annanay25
approved these changes
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Without this change, the generator uses node storage and is not constrianed, and could lead to resource contention on the node.
Here we include a request/limit resource on the generator deployment and an emptydir to constrian the use of local storage.. A side effect of this change is that metrics generator instances will be asked to terminate if the limit is exceeeded, and a new instance will be created. Storage values should be sufficiently high in order to prevent unnecessary churn on the deployment and memberlist. If the requested size is not available, the pod will fail to schedule and could lead to data loss.
Which issue(s) this PR fixes:
Fixes grafana/tempo-squad#91
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]