Add span size as a new metrics to metrics generator#1662
Merged
zalegrala merged 2 commits intografana:mainfrom Aug 19, 2022
ie-pham:jennie/1615
Merged
Add span size as a new metrics to metrics generator#1662zalegrala merged 2 commits intografana:mainfrom ie-pham:jennie/1615
zalegrala merged 2 commits intografana:mainfrom
ie-pham:jennie/1615
Conversation
ie-pham
changed the title
ie-pham
requested review from
annanay25,
joe-elliott,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
ie-pham
changed the title
ie-pham
changed the title
zalegrala
reviewed
Aug 19, 2022
Contributor
zalegrala
left a comment
zalegrala
left a comment
There was a problem hiding this comment.
Nice this looks good to me. Re running the failing test.
zalegrala
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR adds span size as a new metrics to metrics generator.
Which issue(s) this PR fixes:
Fixes #1615
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]