Improve configuration warnings testing and presentation#1663
Merged
joe-elliott merged 3 commits intografana:mainfrom Aug 23, 2022
Merged
Improve configuration warnings testing and presentation#1663joe-elliott merged 3 commits intografana:mainfrom
joe-elliott merged 3 commits intografana:mainfrom
Conversation
|
|
frzifus
force-pushed
the
improve_Warnings_testing_and_presentation
branch
from
03f04d8 to
2556b09
Compare
joe-elliott
reviewed
Aug 22, 2022
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Love the direction you're taking this. I think a basic test that confirms warnings are returned for various configs is all we need.
Contributor
Author
|
perfect, then i will continue. Thanks for feedback @joe-elliott ! |
frzifus
force-pushed
the
improve_Warnings_testing_and_presentation
branch
2 times, most recently
from
870b9fa to
315a411
Compare
frzifus
requested review from
annanay25,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
frzifus
force-pushed
the
improve_Warnings_testing_and_presentation
branch
from
315a411 to
f887e26
Compare
Contributor
Author
|
mh.. linting should be fixed and hope the other changes did not cause |
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
improve_Warnings_testing_and_presentation
branch
from
f887e26 to
820322b
Compare
Contributor
Author
|
Seems my linter fix actually broke the test. I reversed the change and tested it locally. 👍 |
joe-elliott
approved these changes
Aug 23, 2022
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Very nice improvement. Thanks @frzifus!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, would be nice to get some feedback if this roughly looks like what you aimed for. If so, i will continue with persisting the change with some tests. :)cc @joe-elliott @zalegralaWhat this PR does:
This PR changes the behavior of the
cmd/tempo/app/config.CheckConfigmethod. Previously, suspicious values were logged individually. Now a list of warnings and descriptions is returned. The caller can then decide whether and how to use this information. In this PR we decided to reproduce the existing logging behavior.Which issue(s) this PR fixes:
Fixes #1575
Checklist
Documentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]