Parquet: Make FindTraceByID honor buffer and caching settings#1697
Merged
joe-elliott merged 5 commits intografana:mainfrom Aug 29, 2022
Merged
Parquet: Make FindTraceByID honor buffer and caching settings#1697joe-elliott merged 5 commits intografana:mainfrom
joe-elliott merged 5 commits intografana:mainfrom
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
mdisibio
reviewed
Aug 26, 2022
Signed-off-by: Joe Elliott <number101010@gmail.com>
Contributor
The nil panic is probably due to how trace by id search inspects page bounds to do a binary search for the trace, minimizes reads of the page bodies. Do you have any more info about the benefits of skipping bloom filters? |
Collaborator
Author
I can actually detect no difference between SkipBloomFilters true or false. I'm going to remove. |
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
changed the title
mdisibio
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Skip bloom filters when loading for trace by id search. (Skipping page index caused an nil pointer panic)Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]