Implement generic forwarder#1775
Implement generic forwarder#1775mapno merged 12 commits intografana:mainfrom Blinkuu:implement_generic_forwarder
Conversation
mapno
left a comment
There was a problem hiding this comment.
Overall, looks very good to me. I only find the manager logic to be complicated and difficult to follow. Left a comment.
Will wait to see if anyone else wants to chip in.
joe-elliott
left a comment
There was a problem hiding this comment.
This is a large PR that will require several hours to give a proper review to. Is there anyway to break the refactor up from the functionality addition?
|
This PR is now rebased on top of #1796. That PR must be merged before this one. |
joe-elliott
left a comment
There was a problem hiding this comment.
I think we can reduce the complexity of this PR significantly. Let me know if some of these comments are unclear.
mapno
left a comment
There was a problem hiding this comment.
I think it's almost there. Great work 👏
joe-elliott
left a comment
There was a problem hiding this comment.
One final question and then I'm good.
What this PR does:
This PR introduces a new subcomponent to
distributornamedforwarder. This generic forwarder serves as a facade for forwarding batches of spans in "fire-and-forget" way. The feature is designed in such a way that it's configurable on per-tenant basis.Example configuration:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]