metrics-generator: truncate label names and values exceeding a configurable length#1897
Merged
yvrhdn merged 3 commits intografana:mainfrom Nov 17, 2022
Merged
Conversation
yvrhdn
requested review from
annanay25,
joe-elliott,
knylander-grafana,
mapno,
mdisibio and
zalegrala
as code owners
yvrhdn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Metrics backends will often enforce a maximum label name and label value length to protect their inner working. E.g. for label values Prometheus has
label_value_length_limit(default = 0), Mimir hasmax_label_value_length(default = 2048).This PR adds configuration parameters
max_label_name_legnth(defaults to 1024) andmax_label_value_length(defaults to 2048) to optionally truncate label names and values. The defaults match the defaults from Mimir (Prometheus validation is disabled by default).Which issue(s) this PR fixes:
Fixes #1804
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]