Parquet WAL Improvements: Multitenant envs#1945
Merged
joe-elliott merged 15 commits intografana:mainfrom Dec 16, 2022
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
mdisibio
approved these changes
Dec 12, 2022
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Nice improvement. Left one question. Probably ok since tests are passing.
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Collaborator
Author
|
This has been approved and tests are passing, but I'm holding on merging. Still investigating the behavior of some small changes. |
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Collaborator
Author
|
Currently waiting on this PR: #1953 to prevent a performance regression in this branch. |
Signed-off-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
A number of performance improvements for the Parquet wal that are particularly impactful in a highly multitenant environment:
The real winners here were the 1k page buffer size and the lazy loading of the wal page files (instead of loading them immediately after flushing).
By default the page buffer size is 256KB. This page buffer is applied to every column of every tenant which adds up fast. Ideally there would be a way to specify per column page buffers, but this does not exist. The 1KB size does slow down tests. It doubles the length of time to run the tests in the
/tempodb/walfolder for me, but in practice it seemed to have negligible impact on flush times in real environments.