Collect inspectedBytes from SearchMetrics#1975
Merged
joe-elliott merged 3 commits intografana:mainfrom Jan 9, 2023
Merged
Conversation
joe-elliott
approved these changes
Jan 5, 2023
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
do we need the metric? the changes to the log line will make it easy to calculate this metric using loki
| var ( | ||
| metricInspectedBytes = promauto.NewHistogram(prometheus.HistogramOpts{ | ||
| Namespace: "tempo", | ||
| Name: "frontend_query_results_metrics_inspected_bytes", |
Collaborator
There was a problem hiding this comment.
other metrics from this module are named "query_frontend...
e.g. https://github.com/grafana/tempo/blob/main/modules/frontend/retry.go#L18
Member
Author
There was a problem hiding this comment.
will rename the metric.
Member
Author
I am leaning on the side of keeping the metric for now, and testing it out in dev. we can remove if it's not useful. also OSS users might not have Loki for logs. |
electron0zero
requested review from
annanay25,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
joe-elliott
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]