Add TLS support to jaeger query plugin#1999
Merged
mapno merged 2 commits intografana:mainfrom Jan 17, 2023
Merged
Conversation
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
mapno
approved these changes
Jan 17, 2023
Contributor
|
LGTM. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com
What this PR does:
This PR adds options to HTTP client to do TLS handshake with the query-frontend tempo API.
Something similar to what other components have:
Here is an example of the tempo-query config:
Which issue(s) this PR fixes:
Fixes #1998
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]